-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh record-structs branch with latest bits from master #51365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support multiple positions in AutomaticLineEnderTests
- Had to add add a project reference to the corresponding editor APIs in Microsoft.CodeAnalysis.CSharp.Features.csproj. - Prefixed our ExternalAccess API's with "Razor" to not conflict in symbol recognition when working in the Roslyn solution. - Added a non-test method to the `CSharpProximityExpressionService` (which is already internal) to expose a more first class way in getting proximity expressiosn from a syntax tree (doesn't need to be async). This API still isn't accessible on the `IProximityExpressionService` since Razor doesn't want to actually be in the business of resolving full on services and in this case doesn't actually need to. Fixes dotnet/aspnetcore#29547
…esolver.cs Co-authored-by: Sam Harwell <sam.harwell@microsoft.com>
Co-authored-by: Sam Harwell <sam.harwell@microsoft.com>
Co-authored-by: Sam Harwell <sam.harwell@microsoft.com>
These files are based on dotnet/runtime@cf258a14 (v5.0.0-rtm.20519.4).
Optimize option lookup allocations
Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Expand Edit.SmartBreakline to cover more scenario
…o-master Merge release/dev16.10 to master
Avoid capture allocation in AnalyzerFileReference.GetSupportedLanguages
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
Handle failed SaveAsync operations
Provide structured information in binlog for the compiler server
…expressions (dotnet#51213) Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Co-authored-by: Bernd Baumanns <familiebaumanns@googlemail.com>
…218.7 (dotnet#51334) [master] Update dependencies from dotnet/arcade
cston
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to pick up PR #51142 into the feature branch to avoid conflicts later on.